Fix: Correct working directory for package resolution in iOS smoke build #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `flutter packages get -v` command in the `ios_smoke_build` job was running in the root directory, while the build itself was performed in the `example` directory. This caused issues with resolving the path dependency `path: ../` for the `glance` package in the example app's `pubspec.yaml`. This commit changes the working directory of the `flutter packages get -v` command to `example`, ensuring that dependencies are resolved correctly for the example app before the build process.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the package resolution issue by updating the working directory for the flutter packages get command in the iOS smoke build job.
- Moved the execution of "flutter packages get -v" into the "example" directory.
- Updated the job step name to improve clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failed job: https://github.com/littleGnAl/glance/actions/runs/15158653850/job/42619382303?pr=69
The
flutter packages get -vcommand in theios_smoke_buildjob was running in the root directory, while the build itself was performed in theexampledirectory. This caused issues with resolving the path dependencypath: ../for theglancepackage in the example app'spubspec.yaml.This commit changes the working directory of the
flutter packages get -vcommand toexample, ensuring that dependencies are resolved correctly for the example app before the build process.