Skip to content

Issue 958 #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Marky-Shi merged 5 commits into from
Nov 21, 2022
Merged

Issue 958 #959

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2885018
fix parachain staking benchmark code
Nov 18, 2022
9e97fef
fix syntax
Nov 18, 2022
c8aa1e5
omit CollatorSelection benchmark code
Nov 18, 2022
052eb43
[benchmarking bot] Auto commit generated weights files (#961)
github-actions[bot] Nov 21, 2022
3bc731f
Merge branch 'dev' into issue_958
Marky-Shi Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pallets/parachain-staking/src/benchmarking.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use frame_benchmarking::{account, benchmarks, impl_benchmark_test_suite};
use frame_support::traits::{Currency, Get, OnFinalize, OnInitialize, ReservableCurrency};
use frame_system::RawOrigin;
use pallet_authorship::EventHandler;
use sp_runtime::{Perbill, Percent};
use sp_runtime::{Perbill, Percent, Saturating};
use sp_std::{collections::btree_map::BTreeMap, vec, vec::Vec};

/// Minimum collator candidate stake
Expand Down Expand Up @@ -224,9 +224,11 @@ benchmarks! {
assert_eq!(Pallet::<T>::total_selected(), 100u32);
}

set_collator_commission {}: _(RawOrigin::Root, Perbill::from_percent(33))
set_collator_commission {
let new_perbill = <T as Config>::DefaultCollatorCommission::get().saturating_add(Perbill::from_percent(1));
}: _(RawOrigin::Root, new_perbill)
verify {
assert_eq!(Pallet::<T>::collator_commission(), Perbill::from_percent(33));
assert_eq!(Pallet::<T>::collator_commission(), new_perbill);
}

set_blocks_per_round {}: _(RawOrigin::Root, 1200u32)
Expand Down
2 changes: 1 addition & 1 deletion runtime/litentry/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ runtime-benchmarks = [
"pallet-multisig/runtime-benchmarks",
# This module timed out for some reason and had to be commented out temporarily
# https://github.com/litentry/litentry-parachain/actions/runs/3155868677/jobs/5134984739
# "pallet-parachain-staking/runtime-benchmarks",
# "pallet-parachain-staking/runtime-benchmarks",
"pallet-preimage/runtime-benchmarks",
"pallet-proxy/runtime-benchmarks",
"pallet-scheduler/runtime-benchmarks",
Expand Down
4 changes: 2 additions & 2 deletions runtime/litmus/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,8 @@ runtime-benchmarks = [
"pallet-asset-manager/runtime-benchmarks",
"pallet-balances/runtime-benchmarks",
"pallet-bounties/runtime-benchmarks",
#This module returned an error when ran the benchmark, temporarily chose to comment it out
# "pallet-collator-selection/runtime-benchmarks",
# This module returned an error when ran the benchmark, temporarily chose to comment it out
#"pallet-collator-selection/runtime-benchmarks",
"pallet-collective/runtime-benchmarks",
"pallet-democracy/runtime-benchmarks",
"pallet-membership/runtime-benchmarks",
Expand Down
2 changes: 1 addition & 1 deletion runtime/litmus/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ mod benches {
[pallet_scheduler, Scheduler]
[pallet_preimage, Preimage]
[pallet_session, SessionBench::<Runtime>]
//This module returned an error when ran the benchmark, temporarily chose to comment it out
// This module returned an error when ran the benchmark, temporarily chose to comment it out
// [pallet_collator_selection, CollatorSelection]
[cumulus_pallet_xcmp_queue, XcmpQueue]
[pallet_identity_management, IdentityManagement]
Expand Down