-
Notifications
You must be signed in to change notification settings - Fork 18
Update v0.9.30 #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update v0.9.30 #942
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b3658e5
some deps update to v0.9.30
db50c4f
deps update to v0.9.30
190d42e
Merge branch 'dev' into upgrade_v0.9.30
Marky-Shi 28edaf3
format code
2b02b64
change deps
6e2fd99
Merge branch 'dev' into upgrade_v0.9.30
Marky-Shi 735db19
fix docker file
4645565
Merge branch 'upgrade_v0.9.30' of https://github.com/litentry/litentr…
3e03ab2
Merge branch 'dev' into upgrade_v0.9.30
Marky-Shi a24cee7
fix docker file
08d01de
change docker file
7748892
change docker file
9371d0d
fix docker yml file
dfe7e31
fix docker yml file
49ad240
fix docker yml file
3d855b2
add install dependencis shell
2e2b329
fix install dependencis shell
d83a332
fix install dependencis shell
9fbc750
fix docker file
e0fb689
fix yml file
a2177a2
add sudo permisson
5b5a9d1
add some dep
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -107,6 +107,12 @@ jobs: | |
| target: wasm32-unknown-unknown | ||
| default: true | ||
|
|
||
| - name: Install protobuf | ||
| run: | | ||
| sudo apt-get update && \ | ||
| sudo apt-get upgrade -y && \ | ||
| sudo apt-get install -yq openssl clang libclang-dev cmake protobuf-compiler | ||
|
|
||
| - name: Run cargo clippy check | ||
| run: make clippy | ||
|
|
||
|
|
@@ -299,6 +305,12 @@ jobs: | |
| chmod +x $HOME/.local/bin/sccache | ||
| echo "$HOME/.local/bin" >> $GITHUB_PATH | ||
|
|
||
| - name: Install protobuf | ||
| run: | | ||
| sudo apt-get update && \ | ||
| sudo apt-get upgrade -y && \ | ||
| sudo apt-get install -yq openssl clang libclang-dev cmake protobuf-compiler | ||
|
Comment on lines
+311
to
+312
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above |
||
|
|
||
| - name: Cache cargo registry | ||
| if: needs.check-file-change.outputs.src == 'true' | ||
| uses: actions/cache@v3 | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please remove the
upgrade -yline and only install the needed deps? The step name is "install protobuf" but you are installing a lot more than just protobufThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out the deficiencies in the code, for this issue I will open an issue specifically to fix it