Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,12 @@ jobs:
target: wasm32-unknown-unknown
default: true

- name: Install protobuf
run: |
sudo apt-get update && \
sudo apt-get upgrade -y && \
sudo apt-get install -yq openssl clang libclang-dev cmake protobuf-compiler
Comment on lines +113 to +114
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the upgrade -y line and only install the needed deps? The step name is "install protobuf" but you are installing a lot more than just protobuf

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out the deficiencies in the code, for this issue I will open an issue specifically to fix it


- name: Run cargo clippy check
run: make clippy

Expand Down Expand Up @@ -299,6 +305,12 @@ jobs:
chmod +x $HOME/.local/bin/sccache
echo "$HOME/.local/bin" >> $GITHUB_PATH

- name: Install protobuf
run: |
sudo apt-get update && \
sudo apt-get upgrade -y && \
sudo apt-get install -yq openssl clang libclang-dev cmake protobuf-compiler
Comment on lines +311 to +312
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above


- name: Cache cargo registry
if: needs.check-file-change.outputs.src == 'true'
uses: actions/cache@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Install additional dependencies
run: |
sudo apt update -y &&
sudo apt install -y cmake pkg-config libssl-dev git gcc build-essential git clang libclang-dev
sudo apt install -y cmake pkg-config libssl-dev git gcc build-essential git clang libclang-dev

- name: Install cargo-tarpaulin
run: |
Expand Down
Loading