Add 'groupie-ktx' module for extension functions#431
Open
jack-webb wants to merge 2 commits intolisawray:masterfrom
Open
Add 'groupie-ktx' module for extension functions#431jack-webb wants to merge 2 commits intolisawray:masterfrom
jack-webb wants to merge 2 commits intolisawray:masterfrom
Conversation
jack-webb
force-pushed
the
groupie-ktx-module
branch
from
9d184e8 to
e77c600
Compare
jack-webb
commented
Sep 9, 2022
Comment on lines
57
to
65
| ```kotlin | ||
| groupAdapter += HeaderItem() | ||
| groupAdapter += CommentItem() | ||
| groupAdapter.add(HeaderItem()) | ||
| groupAdapter.add(CommentItem()) | ||
|
|
||
| val section = Section() | ||
| section.setHeader(HeaderItem()) | ||
| section.addAll(bodyItems) | ||
| groupAdapter += section | ||
| groupAdapter.add(section) | ||
| ``` |
Author
There was a problem hiding this comment.
AFAICT this part of the readme was wrong. groupie-kotlin-android-extensions wasn't mentioned before this point, so you wouldn't have the dependency necessary to use the overloaded functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the following todo:
With
groupie-kotlin-android-extensionsnow deprecated, I've taken to removing it as a dependency in my projects. The module also includes the extension functions forplusAssign/minusAssign, which aren't deprecated, and I'd like to continue using.This PR moves these extensions to a new module,
groupie-ktx, so they can be depended upon without including the synthetics stuff. The existinggroupie-kotlin-android-extensionsnow depends on this newgroupie-ktx, to avoid duplicating code between the two.