Skip to content

[Monit] Fix in memory_checker, skip fetching running containers if Docker engine is not running #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liorghub wants to merge 3 commits into from
Closed

[Monit] Fix in memory_checker, skip fetching running containers if Docker engine is not running #30

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07d2da3
[Monit] Fix in memory_checker, skip fetching running containers if Do…
liorghub Jul 18, 2022
809f828
Fix review comments
liorghub Jul 18, 2022
5d3574a
Fix second review comments
liorghub Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions files/image_config/monit/memory_checker
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import subprocess
import sys
import syslog
import re
import os

import docker

Expand Down Expand Up @@ -97,9 +96,9 @@ def check_memory_usage(container_name, threshold_value):
sys.exit(4)


def is_service_active(feat):
status = os.system('systemctl is-active --quiet {}'.format(feat))
return status == 0
def is_service_active(service):
status = subprocess.run("systemctl is-active --quiet {}".format(service), shell=True, check=False)
return status.returncode == 0


def get_running_container_names():
Expand All @@ -111,18 +110,19 @@ def get_running_container_names():
Returns:
running_container_names: A list indicates names of running containers.
"""
running_container_names = []

if (is_service_active("docker")):
try:
docker_client = docker.DockerClient(base_url='unix://var/run/docker.sock')
running_container_list = docker_client.containers.list(filters={"status": "running"})
running_container_names = [ container.name for container in running_container_list ]
except (docker.errors.APIError, docker.errors.DockerException) as err:
syslog.syslog(syslog.LOG_ERR,
"Failed to retrieve the running container list from docker daemon! Error message is: '{}'"
.format(err))
sys.exit(5)
if not is_service_active("docker"):
syslog.syslog(syslog.LOG_INFO,"Skipping memory check since Docker engine is down")
return []

try:
docker_client = docker.DockerClient(base_url='unix://var/run/docker.sock')
running_container_list = docker_client.containers.list(filters={"status": "running"})
running_container_names = [ container.name for container in running_container_list ]
except (docker.errors.APIError, docker.errors.DockerException) as err:
syslog.syslog(syslog.LOG_ERR,
"Failed to retrieve the running container list from docker daemon! Error message is: '{}'"
.format(err))
sys.exit(5)

return running_container_names

Expand Down