-
Notifications
You must be signed in to change notification settings - Fork 14
feat: insights leaderboard #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
…n/insights into feat/insights-leaderboard
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conventional Commits FTW!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR titles must follow Conventional Commits. Love from, Your reviewers ❤️.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a comprehensive leaderboards feature for the LFX Insights frontend application. The implementation allows users to explore and compare open source projects across various performance metrics.
Key changes:
- Adds leaderboard pages with routing for landing and detail views
- Implements six leaderboard configurations (active contributors, active organizations, longest running, commit activity, focused teams, and small teams with massive output)
- Creates API service layer with infinite scroll pagination support
- Adds "ghost" button type to the UI kit
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
frontend/app/pages/leaderboards/index.vue |
Landing page displaying all leaderboard categories |
frontend/app/pages/leaderboards/[key].vue |
Dynamic detail page for individual leaderboards |
frontend/app/config/menu/index.ts |
Adds leaderboards entry to main navigation menu |
frontend/app/components/uikit/button/types/button.types.ts |
Extends button types with "ghost" variant |
frontend/app/components/uikit/button/button.scss |
Styles for ghost button variant |
frontend/app/components/shared/types/tanstack.ts |
Adds query keys for leaderboard data fetching |
frontend/app/components/shared/types/routes.ts |
Defines leaderboard route constants |
frontend/app/components/modules/leaderboards/services/leaderboard.api.service.ts |
API service for fetching and managing leaderboard data |
frontend/app/components/modules/leaderboards/config/*.ts |
Configuration files defining each leaderboard's metadata |
frontend/app/components/modules/leaderboards/components/views/*.vue |
Main view components for landing and detail pages |
frontend/app/components/modules/leaderboards/components/sections/*.vue |
Reusable section components (cards, tables, headers, sidebar) |
frontend/app/components/modules/leaderboards/components/data-displays/*.vue |
Components for formatting and displaying metric values |
frontend/app/components/modules/leaderboards/README.md |
Documentation for the leaderboards module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Efren Lim <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add caching for api calls and pages and also implement stuff for remaining leaderboards and comment it out
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
Signed-off-by: Efren Lim <[email protected]>
In this PR
Ticket
IN-816