Skip to content

Conversation

@balaraj74
Copy link

Summary

This pull request addresses issue #618 by changing the visual representation of security items that cannot be accurately measured. Previously, these items were displayed with an orange/yellow warning badge, which gave users the impression that something was wrong. The fix changes the color to a neutral grey, making it clear that these items simply cannot be measured rather than indicating a problem.

Changes Made

  • Updated the NEEDS_REVIEW status tag to use neutral variation instead of warning-solid
  • Changed the icon from exclamation-triangle to question-circle for better clarity
  • Updated the display text from "Needs review" to "Cannot measure" to be more explicit
  • Verified that score calculation already excludes these items from affecting the overall score

Testing

  • Tested the component in isolation to verify the visual changes
  • Confirmed that the grey color no longer implies a warning or error state
  • Verified that items marked as "Cannot measure" are excluded from score calculations

Screenshots

The fix changes the appearance from an orange warning badge to a grey neutral badge, removing any negative implication for items that cannot be measured.

Fixes #618

Items that cannot be accurately measured were previously displayed with
an orange/yellow warning badge, which implied something was wrong. This
change updates the visual representation to use a neutral grey color
instead, making it clear that these items simply cannot be measured
rather than indicating a problem.

Changes:
- Updated NEEDS_REVIEW status to use neutral variation instead of warning-solid
- Changed icon from exclamation-triangle to question-circle
- Updated text from 'Needs review' to 'Cannot measure'
- Score calculation already excludes these items from affecting the overall score

Fixes linuxfoundation#618

Signed-off-by: balaraj74 <[email protected]>
Copilot AI review requested due to automatic review settings October 31, 2025 19:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a UX issue where unmeasurable security items were displaying with an orange warning badge, incorrectly implying something was wrong. The fix changes the visual representation to use neutral grey styling to clearly indicate these items simply cannot be measured.

  • Updated the NEEDS_REVIEW status to use neutral variation instead of warning-solid
  • Changed the icon from exclamation-triangle to question-circle for better semantic clarity
  • Updated display text from "Needs review" to "Cannot measure" for more explicit messaging

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
submodules/crowd.dev Submodule commit update
frontend/app/components/modules/project/components/security/evaluation-result-tag.vue Updated NEEDS_REVIEW status styling and text to use neutral appearance

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@balaraj74
Copy link
Author

Summary

This pull request addresses issue #618 by changing the visual representation of security items that cannot be accurately measured. Previously, these items were displayed with an orange/yellow warning badge, which gave users the impression that something was wrong. The fix changes the color to a neutral grey, making it clear that these items simply cannot be measured rather than indicating a problem.

Changes Made

  • Updated the NEEDS_REVIEW status tag to use neutral variation instead of warning-solid
  • Changed the icon from exclamation-triangle to question-circle for better clarity
  • Updated the display text from "Needs review" to "Cannot measure" to be more explicit
  • Verified that score calculation already excludes these items from affecting the overall score

Testing

  • Tested the component in isolation to verify the visual changes
  • Confirmed that the grey color no longer implies a warning or error state
  • Verified that items marked as "Cannot measure" are excluded from score calculations

Screenshots

The fix changes the appearance from an orange warning badge to a grey neutral badge, removing any negative implication for items that cannot be measured.

Fixes #618

image

…aluation-result-tag.vue

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Balaraj R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change color of things you can't measure to grey / white

1 participant