Skip to content

Conversation

@mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Nov 3, 2025

(来自设计摘要)

更新时间2025.11.3更新内容:

1.organic-glass新增部分自研应用。(解决organ-glass主题全局搜索、云盘不显示对应主题图标问题)

2.square主题补充部分应用、文件夹、设备图标。(解决squre主题全局搜索、云盘不显示对应主题图标问题)

3.百度网盘uos.web.baidu.pan,所有主题新增快捷方式baidunetdisk(商店重新打包改名,避免旧的版本失效,在原来图标基础上新增快捷方式)

4.origin主题中文件夹快捷方式user-desktop.dci与inode-directory.dci命名错误,原来这两个图标命名后面多了一个“;”符号,导致无法显示,现在修正(修复计算机-我的目录中的桌面图标无法正常显示问题)

5.origin、nirvana主题更新部分文件类型。(修复word文档的图标上面缩写不准确问题)

6.flow、hazy-color、macaron更新部分应用图标。

Log: update theme icons

Summary by Sourcery

Update and standardize theme icons by adding new app shortcuts, supplementing missing icons, correcting naming and display issues, and refreshing file-type and application icons across multiple themes

New Features:

  • Add BaiduNetDisk shortcut icon across all themes
  • Add self-developed app icons to organic-glass theme
  • Supplement app, folder, and device icons in square theme

Bug Fixes:

  • Fix missing theme icons in global search and cloud drive for organic-glass and square themes
  • Correct folder shortcut icon naming in origin theme to restore desktop icon
  • Correct Word document icon abbreviations in origin and nirvana themes

Enhancements:

  • Update application icons in flow, hazy-color, and macaron themes

(来自设计摘要)

更新时间2025.11.3更新内容:

1.organic-glass新增部分自研应用。(解决organ-glass主题全局搜索、云盘不显示对应主题图标问题)

2.square主题补充部分应用、文件夹、设备图标。(解决squre主题全局搜索、云盘不显示对应主题图标问题)

3.百度网盘uos.web.baidu.pan,所有主题新增快捷方式baidunetdisk(商店重新打包改名,避免旧的版本失效,在原来图标基础上新增快捷方式)

4.origin主题中文件夹快捷方式user-desktop.dci与inode-directory.dci命名错误,原来这两个图标命名后面多了一个“;”符号,导致无法显示,现在修正(修复计算机-我的目录中的桌面图标无法正常显示问题)

5.origin、nirvana主题更新部分文件类型。(修复word文档的图标上面缩写不准确问题)

6.flow、hazy-color、macaron更新部分应用图标。

Log: update theme icons
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 3, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR systematically updates theme icons by adding the BaiduNetDisk shortcut icon across all themes, enriching the square theme with additional application icons, correcting misnamed folder shortcuts in the origin theme, and revising Word document file type icons in the origin theme to ensure accurate display.

File-Level Changes

Change Details Files
Add BaiduNetDisk shortcut icon to all themes
  • Introduced baidunetdisk.dci icon for quick launch
flow/dsg-icons/flow/baidunetdisk.dci
hazy-color/dsg-icons/hazy-color/baidunetdisk.dci
macaron/dsg-icons/macaron/baidunetdisk.dci
nirvana/dsg-icons/nirvana/baidunetdisk.dci
organic-glass/dsg-icons/organic-glass/baidunetdisk.dci
origin/dsg-icons/origin/baidunetdisk.dci
square/dsg-icons/square/baidunetdisk.dci
vintage/dsg-icons/vintage/baidunetdisk.dci
Enrich square theme with additional application icons
  • Added icons for EdrawSoft, Easy7Zip, MoonPlayer, Feige, 7-zip and Remmina
square/dsg-icons/square/cn.edrawsoft.dci
square/dsg-icons/square/com.easy7zip.deepin.dci
square/dsg-icons/square/com.github.coslyk.MoonPlayer.dci
square/dsg-icons/square/feige.dci
square/dsg-icons/square/org.7-zip.deepin.dci
square/dsg-icons/square/org.remmina.dci
Fix misnamed folder shortcut icons in origin theme
  • Removed trailing semicolon from user-desktop.dci and inode-directory.dci filenames
origin/dsg-icons/origin/user-desktop.dci
origin/dsg-icons/origin/inode-directory.dci
Update Word document file type icons in origin theme
  • Introduced proper OpenXML and WPS .doc/.docx icons for Word documents
origin/dsg-icons/origin/application-vnd.ms-word.dci
origin/dsg-icons/origin/application-vnd.openxmlformats-officedocument.wordprocessingml.document.dci
origin/dsg-icons/origin/application-wps-office.doc.dci
origin/dsg-icons/origin/application-wps-office.docx.dci

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

deepin pr auto review

这是一个关于系统图标的 Git diff,主要涉及多个图标主题(flow、hazy-color、macaron、nirvana、organic-glass、origin、square、vintage)下的图标文件变更。让我进行详细分析:

  1. 代码逻辑分析:
  • 大部分变更都是新增图标文件(.dci)
  • 有一些符号链接的创建(如 baidunetdisk.dci 指向 uos.web.baidu.pan.dci)
  • 有一些文件权限的变更(如 origin/dsg-icons/origin/folder-desktop.dci 和 folder.dci 从 644 变为 755)
  • 有一些文件的重命名和删除(如 origin 下的 Word 相关图标)
  1. 代码质量评估:
    优点:
  • 使用符号链接来复用图标,避免了重复存储
  • 文件命名规范,遵循了反向域名命名规则
  • 按主题分类组织图标,结构清晰

改进建议:

  • 建议添加一个文档说明图标的命名规范和主题分类规则
  • 对于权限变更(如 folder*.dci 从 644 变为 755),建议说明变更原因
  • 建议统一符号链接的路径格式(有些使用相对路径,有些使用绝对路径)
  1. 性能分析:
  • 使用符号链接可以节省存储空间
  • 文件结构合理,不会影响系统性能
  • 二进制文件的变更无法进行内容比较,建议添加版本控制
  1. 安全性评估:
  • 文件权限变更需要谨慎,特别是从 644 变为 755(增加了执行权限)
  • 建议检查新增图标的来源和完整性
  • 符号链接需要确保目标文件存在且可访问
  1. 具体建议:
  • 对于 Word 相关图标的合并,建议添加迁移说明
  • 新增的 AI 相关图标(如 UosAiAgent.dci)建议添加使用说明
  • 建议为不同主题下的相同图标建立统一的版本控制
  • 对于二进制文件,建议添加校验和或版本信息
  1. 其他注意事项:
  • 建议保持图标主题之间的一致性
  • 新增的百度网盘图标(baidunetdisk.dci)在不同主题下都使用了相同的符号链接方式,这种做法很好
  • 建议定期检查符号链接的有效性

总体来说,这次变更组织良好,但需要更多的文档说明和安全性考虑。特别是权限变更和二进制文件的管理需要更加谨慎。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mhduiy, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy mhduiy merged commit 30aeefa into linuxdeepin:master Nov 4, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants