Skip to content

Conversation

@tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Sep 4, 2024

fix bugs introduced by #1698:

  • whiptail_error was self calling itself in case no usb security dongle was connected instead of asking the user to plug it in and try again
  • whiptail_error and whiptail_warning are overrides of sourced /etc/gui_functions
    • therefore, whiptail_error calling whiptail_error was self calling passing wrong paramters and whiptail prompt was never showed.
    • fixed by renaming oem-factory-reset's whiptail_error into local_whiptail_error function and changing whiptail_error_die and the only place where this fonction was called directly

Superseeds #1777

Addresses #1395 (comment) : thanks for reporting @arhabd


No need for review after testing, "emergency" bugfix

…lfcalling itself, fix typo in gui-init

fix bugs introduced by linuxboot#1698

Signed-off-by: Thierry Laurion <[email protected]>
@tlaurion
Copy link
Collaborator Author

tlaurion commented Sep 4, 2024

Tested on qemu and x230. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant