ci: rollout several recent changes to CI testing#299
Merged
Conversation
* Pass in a YAML true value as `__bootc_validation: true` using
the --extra-vars option to ensure that `__bootc_validation` is
treated as a boolean and not a string value.
`-e "__bootc_validation: true"`
You can also use JSON format:
`-e '{"__bootc_validation": true}'`
but YAML is simpler in this case.
* Use tox-lsr version 3.11.1
* Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
* Update contributing.md documentation
* Update number of nodes to use in testing farm, if needed
* remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's GuideThis PR refines CI testing by enforcing a YAML boolean for bootc validation, upgrading tox-lsr to 3.11.1 across workflows, enhancing TF test cancellation detection in the citest bad comment workflow, and expanding CONTRIBUTING.md with detailed local CI testing instructions. Sequence diagram for enhanced TF test cancellation detection in citest bad comment workflowsequenceDiagram
participant "GitHub Actions Workflow"
participant "TF Testing Farm API"
participant "User"
"GitHub Actions Workflow"->>"TF Testing Farm API": Query workflow runs for PR
"TF Testing Farm API"-->>"GitHub Actions Workflow": Return runs with conclusion (failure or cancelled)
alt Run found (failure or cancelled)
"GitHub Actions Workflow"->>"User": Post bad comment for failed/cancelled test
else No run found
"GitHub Actions Workflow"->>"User": Notify workflow not found
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider centralizing the tox-lsr version across all workflows (for example via a reusable action or variable) to avoid manually updating each file when bumping versions.
- The extended qemu testing instructions in contributing.md could be moved to a dedicated guide or linked upstream to keep the main contributing doc concise and easier to maintain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the tox-lsr version across all workflows (for example via a reusable action or variable) to avoid manually updating each file when bumping versions.
- The extended qemu testing instructions in contributing.md could be moved to a dedicated guide or linked upstream to keep the main contributing doc concise and easier to maintain.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__bootc_validation: trueusingthe --extra-vars option to ensure that
__bootc_validationistreated as a boolean and not a string value.
-e "__bootc_validation: true"You can also use JSON format:
-e '{"__bootc_validation": true}'but YAML is simpler in this case.
Use tox-lsr version 3.11.1
Ensure the citest bad comment works when the test was cancelled in
addition to the failure case.
Update contributing.md documentation
Update number of nodes to use in testing farm, if needed
remove unnecessary ansible-lint skips
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Streamline and strengthen CI testing workflows by upgrading the tox-lsr dependency, improving boolean variable handling, extending failure detection, and enriching local test documentation
CI:
Documentation: