refactor: support ansible 2.19; fix ansible-lint issues

[richm]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update tests for Ansible 2.19 compatibility and address ansible-lint issues by renaming variables and clarifying task names.

Tests:

• Use "__ansible_managed" instead of "ansible_managed" in header assertion to comply with linting and Ansible 2.19 conventions
• Rename NTP provider verification task to "Verify provider set correctly - 2" to avoid duplicate task names

[sourcery-ai]

Reviewer's Guide

Refactor tests to support Ansible 2.19 managed header variable naming and fix ansible-lint issues by updating variable names and test descriptions.

File-Level Changes

Change	Details	Files
Adjust ansible managed header variables to comply with Ansible 2.19 changes	Replaced ansible_managed with __ansible_managed in assert condition Updated variable lookup key to __ansible_managed	tests/tasks/check_header.yml
Rename test case to avoid duplicate names and satisfy lint rules	Appended '- 2' to test name 'Verify provider set correctly'	tests/tests_ntp_provider6.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @richm - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[richm]

[citest]