add RPM build support#154
Closed
myrgy wants to merge 1 commit intolinux-on-mac:masterfrom
myrgy:master
Closed
Conversation
codutti
reviewed
Aug 19, 2018
codutti
left a comment
codutti
left a comment
There was a problem hiding this comment.
You should not use systemctl command inside a spec file. There are some macros and best practices to do that. Nevertheless Fedora packaging policies suggest not to run a deamon automatically but let the user configure it before the first run.
Member
|
Let's work together on this in #157. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
might be useful rpm-based systems