nvme: add output-format-version option #2796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
May 7, 2025
nvme-print-json.c
Outdated
| obj_add_str(obj_iocsc, "NVM Command Set", nvmcs ? "Selected" : "Not selected"); | ||
| } | ||
|
|
||
| static bool human(void) |
There was a problem hiding this comment.
While at it, we should rename the function, maybe verbose_mode or something similar.
igaw
reviewed
May 7, 2025
| OPT_SHRT("dir-spec", 'S', &cfg.dspec, dspec_w_dtype), | ||
| OPT_BYTE("dir-oper", 'O', &cfg.doper, doper), | ||
| OPT_SHRT("endir", 'e', &cfg.endir, endir), | ||
| OPT_FLAG("human-readable", 'H', &cfg.human_readable, human_readable_directive), |
There was a problem hiding this comment.
Best leave it the option around, just to avoid to break anyone. Couldn't we map it to verbose mode ?
There was a problem hiding this comment.
But if there is no user left, just leave the option. You could add a help text like deprecated; does nothing
|
Looks really good. Thanks a lot! |
The JSON outputs changed to verbose by the format version 2. Signed-off-by: Tokunori Ikegami <[email protected]>
Since the option is not used by the command actually. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
output-format-ver
branch
from
cc113a1 to
7690a7c
Compare
|
Fixed the commits as suggested. Thank you. |
|
Thanks! Maybe we should also update the documentation on |
Noted so will do later. Thank you. |
This was referenced May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON outputs changed to verbose by the format version 2.