Skip to content

Fixed the issue of response handling errors when program key multiple… #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2025
Merged

Fixed the issue of response handling errors when program key multiple… #2704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions nvme-rpmb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,9 +629,10 @@ static int rpmb_program_auth_key(int fd, unsigned char target,
/* reuse response buffer */
memset(rsp, 0, rsp_size);
err = recv_rpmb_rsp(fd, req->target, rsp_size, rsp);
if (err != 0) {
if (err != 0)
fprintf(stderr, "Program Key recv error = 0x%x\n", err);
else
err = check_rpmb_response(req, rsp, "Failed to Program Key");
}
out:
Copy link
Collaborator

@igaw igaw Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the style from above, test for error print warning bail out. Also check the coding style. The commit message needs also more attention.

free(req);
free(rsp);
Expand Down
Loading