Skip to content

Removing unnecessary runtime dependency of core: spotbugs-annotations#2325

Merged
CCisGG merged 1 commit intolinkedin:mainfrom
akatona84:remove-spotbugs-annotation
Oct 28, 2025
Merged

Removing unnecessary runtime dependency of core: spotbugs-annotations#2325
CCisGG merged 1 commit intolinkedin:mainfrom
akatona84:remove-spotbugs-annotation

Conversation

@akatona84
Copy link
Contributor

Summary

  1. Why: spotbugs-annotation is not used, originally was added as findbugs but at wrong scope I believe, but now it's not used at all
  2. What: removing the unused dependency, cleaner dependency tree and not leaking as transitive at other projects (at Strimzi for example)

Expected Behavior

spotbugs-annotation not appearing in the runtime dependencies any more

Actual Behavior

spotbugs-annotation is in the runtime dependencies of cruise control

Steps to Reproduce

  1. run ./gradlew :cruise-control:dependencies
  2. check the output

Known Workarounds

Explicit exclusion is required in projects using the Cruise Control dependency.

Categorization

  • documentation
  • bugfix
  • new feature
  • refactor
  • security/CVE
  • other

Signed-off-by: Andras Katona <akatona@cloudera.com>
@akatona84
Copy link
Contributor Author

@CCisGG could you take a look pls?
license scanner shown this to us, as spotbugs-annotation has a non-permissive license

@CCisGG CCisGG merged commit b2efe56 into linkedin:main Oct 28, 2025
6 checks passed
@CCisGG
Copy link
Contributor

CCisGG commented Oct 28, 2025

@akatona84 Merged. Thanks for the fix!

@akatona84 akatona84 deleted the remove-spotbugs-annotation branch October 28, 2025 20:14
ivonaest pushed a commit to Nordix/cruise-control that referenced this pull request Nov 4, 2025
georgew5656 pushed a commit to DataDog/cruise-control that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants