fix: trans values typing and runtime#2502
Closed
yslpn wants to merge 16 commits intolingui:nextfrom
Closed
Conversation
|
@yslpn is attempting to deploy a commit to the Crowdin Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #2502 +/- ##
===========================================
+ Coverage 76.66% 89.05% +12.38%
===========================================
Files 81 118 +37
Lines 2083 3325 +1242
Branches 532 981 +449
===========================================
+ Hits 1597 2961 +1364
+ Misses 375 329 -46
+ Partials 111 35 -76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR narrows
Transinterpolation values to supported scalar types and fixes the rendering logic to match that contract across@lingui/core,@lingui/react, and macro typings.Before this change, some values were accepted by TypeScript but did not behave correctly at runtime in
Trans.This PR makes the typing stricter
Types of changes
Fixes # (issue)
Checklist