fix: [Good First Issue] 🌸 Add new Japan Fact 236 - Beginner-Friendly#8890
Merged
tentoumushii merged 1 commit intolingdojo:mainfrom Mar 17, 2026
Merged
fix: [Good First Issue] 🌸 Add new Japan Fact 236 - Beginner-Friendly#8890tentoumushii merged 1 commit intolingdojo:mainfrom
tentoumushii merged 1 commit intolingdojo:mainfrom
Conversation
Collaborator
🎉 Thanks for your Pull Request, @JiwaniZakir!We appreciate your contribution to KanaDojo! Pre-merge checklist:
A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run ありがとうございます! 🙏 |
Collaborator
🤖 Auto-Review: ✅ PassedThis fact contribution has passed automated validation! Checks passed:
📎 Linked issue: #8888 Once the quality check passes, this PR will be automatically approved for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8888
Adds fact #236 to
community/content/japan-facts.jsonabout the Japanese concept of 'yoin' (余韻). The file was missing a trailing comma on the previous last entry, which has been corrected as part of appending the new entry. No logic changes -- purely a data addition to the facts array.