Skip to content

fix: [Good First Issue] 🌸 Add new Japan Fact 236 - Beginner-Friendly#8890

Merged
tentoumushii merged 1 commit intolingdojo:mainfrom
JiwaniZakir:fix/issue-8888
Mar 17, 2026
Merged

fix: [Good First Issue] 🌸 Add new Japan Fact 236 - Beginner-Friendly#8890
tentoumushii merged 1 commit intolingdojo:mainfrom
JiwaniZakir:fix/issue-8888

Conversation

@JiwaniZakir
Copy link
Copy Markdown
Contributor

Fixes #8888

Adds fact #236 to community/content/japan-facts.json about the Japanese concept of 'yoin' (余韻). The file was missing a trailing comma on the previous last entry, which has been corrected as part of appending the new entry. No logic changes -- purely a data addition to the facts array.

@tentoumushii
Copy link
Copy Markdown
Collaborator

🎉 Thanks for your Pull Request, @JiwaniZakir!

We appreciate your contribution to KanaDojo!

Pre-merge checklist:

  • You starred our repo ⭐
  • Code follows project style guidelines
  • Changes have been tested locally
  • PR title is descriptive
  • If this closes an issue, it's linked with Closes #<number>

A maintainer will review your PR shortly. In the meantime, make sure all CI checks pass. You can run npm run check locally to match CI.

ありがとうございます! 🙏

@tentoumushii
Copy link
Copy Markdown
Collaborator

🤖 Auto-Review: ✅ Passed

This fact contribution has passed automated validation!

Checks passed:

  • ✅ File format is correct
  • ✅ Content is valid
  • ✅ Related issue found

📎 Linked issue: #8888

Once the quality check passes, this PR will be automatically approved for merge.

@tentoumushii tentoumushii merged commit 0b0241e into lingdojo:main Mar 17, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue] 🌸 Add new Japan Fact 236 - Beginner-Friendly Contribution (good-first-issue, <1 min, no setup)

2 participants