-
Notifications
You must be signed in to change notification settings - Fork 194
Add font embolden #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add font embolden #823
Conversation
f317cd7 to
d4eddc4
Compare
|
Need to investigate:
|
3e7d17e to
420d99d
Compare
|
This is now working. It has path expansion/stem darkening working on the GPU and properly works with Bevel, Miter, and Round joins. These are all configurable. The changes are implemented in both the cpu and gpu flatten shader. |
|
A quick update, this was discussed in Renderer office hours, also see transcript of the discussion. This would be great to have in some form, but the big question is review bandwidth as it's a fairly major change and has a risk of breaking things. We haven't forgotten about it, but need to decide what to do. |
420d99d to
fa91a62
Compare
|
I have updated this PR to allow the embolden to take a vec2 for separate emboldening of x and y. I will add some comments to the PR to highlight parts that need particular review and open questions. |
switch to gpu embolden
fa91a62 to
4131589
Compare
bf15178 to
dba1143
Compare
This is basically just a direct port of the swash implementation of font embolden.It does seem to have about twice the "strength" of the swash implementation though and I haven't been able to figure out why.