Strip whitespace following a newline when whitespace collapsing is enabled #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
strip-whitespace-following-a-newline
branch
from
b6ef606 to
a04ce41
Compare
xorgy
approved these changes
Jan 25, 2025
Member
xorgy
left a comment
xorgy
left a comment
There was a problem hiding this comment.
This makes sense, as long as the documented purpose of WhiteSpaceCollapse::Collapse is to follow the CSS whitespace processing model.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
Adds `tree_builder` to `TestEnv` to be able to set white space collapsing mode. A quick follow-up to #254.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2025
Followup (small bug fix) to #254 which didn't take inline boxes into account. That PR was checking whether "the last character is whitespace" without checking whether the last thing pushed into the layout was text. So if the sequence of items pushed to a layout was something like: - inline box - whitespace - inline box - whitespace - inline box - whitespace - inline box (an example which would be "status badges" in Github readme's which are typically images separated by whitespace characters) Then all but the first "whitespace" would get collapsed as it would be incorrectly detected as directly adjacent to the preceding whitespace (even though it shouldn't because there is an inline box in between). This PR fixes this issue by tracking the kind of the last item pushed. --------- Signed-off-by: Nico Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows https://www.w3.org/TR/CSS2/text.html#white-space-model. Further work will be required to completely match that spec. In particular, whitespace preceding a newline also ought to be stripped but:
This fixes a visible 1-space indent at the start of lines following a
<br />tag in Blitz.