[WIP] Add support for Thrift 0.23.0

[KarboniteKream]

Motivation:

Thrift 0.23.0 has been released, with some breaking changes:

• [THRIFT-5916] Enforce recursion depth limit in Java for C++ parity apache/thrift#3287
• THRIFT-5925: Java UUID fix apache/thrift#3334

Modifications:

• Add the thrift0.23 module
• Override TByteBufTransport to return a default TConfiguration, to handle the first breaking change
• TODO

Result:

• Armeria supports Thrift 0.23.0

[coderabbitai]

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)

• WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e86f29f3-bcab-429e-8993-20a14efb697b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

🔍 Build Scan® (commit: 3211620)

Job name	Status	Build Scan®
build-ubicloud-standard-16-jdk-8	✅	https://ge.armeria.dev/s/52rzmgfjbk2sm
build-ubicloud-standard-16-jdk-25	✅	https://ge.armeria.dev/s/wz5fvhdhv6kge
build-ubicloud-standard-16-jdk-21-snapshot-blockhound	❌ (failure)	https://ge.armeria.dev/s/myfd5sfuupxzi
build-ubicloud-standard-16-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/ojj2nw7z5w7oy
build-ubicloud-standard-16-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/w4xoe5zprqndu
build-ubicloud-standard-16-jdk-17-leak	✅	https://ge.armeria.dev/s/plilxmaorcjki
build-ubicloud-standard-16-jdk-11	✅	https://ge.armeria.dev/s/oarkd3k5c7mxo
build-macos-latest-jdk-25	✅	https://ge.armeria.dev/s/jcoihroge3tt6

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.65%. Comparing base (8150425) to head (3211620).
⚠️ Report is 442 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #6762      +/-   ##
============================================
- Coverage     74.46%   73.65%   -0.81%     
- Complexity    22234    24304    +2070     
============================================
  Files          1963     2200     +237     
  Lines         82437    91628    +9191     
  Branches      10764    11959    +1195     
============================================
+ Hits          61385    67487    +6102     
- Misses        15918    18458    +2540     
- Partials       5134     5683     +549     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[KarboniteKream]

We're now returning the default configuration instead of null.
I could just update the thrift0.14 module instead, WDYT?

[ikhoon]

I prefer to update TByteBufTransport in thrift0.14.
By the way, why do we need to change it? Is it because TConfiguration may be used in TProtocol implementations?

[KarboniteKream]

TProtocol started using it, see apache/thrift#3287