Add StreamTimeoutStrategy, StreamTimeoutDecision, and Token-bucket-based timeout limiting strategy#6245
Draft
sjy982 wants to merge 5 commits into
Draft
Add StreamTimeoutStrategy, StreamTimeoutDecision, and Token-bucket-based timeout limiting strategy#6245sjy982 wants to merge 5 commits into
sjy982 wants to merge 5 commits into
Conversation
Contributor
Update TimeoutStreamMessage, TimeoutSubscriber, StreamMessage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6245 +/- ##
============================================
- Coverage 74.46% 0 -74.47%
============================================
Files 1963 0 -1963
Lines 82437 0 -82437
Branches 10764 0 -10764
============================================
- Hits 61385 0 -61385
+ Misses 15918 0 -15918
+ Partials 5134 0 -5134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
StreamMessage.timeout()currently uses a fixed timeout mode. Differentuse-cases may require custom logic, so we introduce a
StreamTimeoutStrategyinterface. The existing
StreamTimeoutModewill remain as the defaultstrategy.
To tolerate transient network jitter, a token-bucket strategy can delay
timeout until a user-defined number of consecutive delays is reached.
Modifications
StreamTimeoutDecisiontimedOut,hasNextSchedule,nextScheduleTimeNanos.TIMED_OUT,NO_SCHEDULE,scheduleAt(long).StreamTimeoutStrategyinterfaceinitialDecision(long subscribeTimeNanos)– called once right aftersubscription.
evaluateTimeout(long currentTimeNanos, long lastEventTimeNanos)– calledeach time the scheduled timer fires.
StreamTimeoutMode) and token-bucket strategy implementationsWill be added in a follow-up commit.
Result
StreamTimeoutStrategytoStreamMessage.timeout(strategy)to control per-stream timeout behaviour.StreamTimeoutModecontinues to work as the default.