Skip to content

fix: e2e tests for readonly shared drive#3959

Merged
doubleface merged 1 commit into
masterfrom
fix/e2eAddUploadReadonlyDisabled
Jun 26, 2026
Merged

fix: e2e tests for readonly shared drive#3959
doubleface merged 1 commit into
masterfrom
fix/e2eAddUploadReadonlyDisabled

Conversation

@doubleface

@doubleface doubleface commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Since #3950 we now disable add and upload buttons on readonly folders and shared drives

Summary by CodeRabbit

  • Tests
    • Updated shared-drive coverage to verify that read-only users still see create and upload actions, but in a disabled state rather than hidden.

Since #3950 we now disable
add and upload buttons on readonly folders and shared drives
@doubleface doubleface added the e2e Run the E2E suite on this PR label Jun 25, 2026

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bbbe1289-32a1-4fb9-8f85-a02ac7e77a64

📥 Commits

Reviewing files that changed from the base of the PR and between 64417f0 and cf9a319.

📒 Files selected for processing (1)
  • e2e/tests/z-shared-drive-members.spec.ts

Walkthrough

The shared-drive members E2E spec was updated so Bob’s read-only drive view now asserts that the Create and Upload controls are visible but disabled instead of hidden. The inline comment in the test was updated to match the new expectation.

Possibly related PRs

Suggested reviewers

  • zatteo
  • lethemanh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: updating e2e tests for readonly shared drive behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/e2eAddUploadReadonlyDisabled

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bundlemon

bundlemon Bot commented Jun 25, 2026

Copy link
Copy Markdown

BundleMon

Unchanged files (20)
Status Path Size Limits
static/js/cozy.(hash).js
928.67KB -
static/resource/(hash).js
336.09KB -
services/qualificationMigration.js
283.39KB -
services/dacc.js
263.13KB -
static/js/(chunkId).(hash).js
82.05KB -
static/js/main.(hash).js
54.03KB -
static/js/lib-react.(hash).js
43.88KB -
static/css/cozy.(hash).css
30.13KB -
static/js/public.(hash).js
25.84KB -
static/js/lib-polyfill.(hash).js
22.77KB -
static/js/lib-router.(hash).js
21.86KB -
static/css/main.(hash).css
13.57KB -
static/js/intents.(hash).js
8.99KB -
static/js/async/(chunkId).(hash).js
7.5KB -
manifest.webapp
5.97KB -
static/css/public.(hash).css
2.34KB -
index.html
772B -
public/index.html
705B -
intents/index.html
643B -
assets/manifest.json
185B -

No change in files bundle size

Unchanged groups (3)
Status Path Size Limits
**/*.js
5.99MB -
**/*.{png,svg,ico}
2.16MB -
**/*.css
77.43KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@doubleface doubleface merged commit 13b362c into master Jun 26, 2026
7 checks passed
@doubleface doubleface deleted the fix/e2eAddUploadReadonlyDisabled branch June 26, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run the E2E suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants