Skip to content

feat(sort): add flag for default updated_at sort on folders#3954

Merged
doubleface merged 1 commit into
masterfrom
feat/updatedAtDefaultSortFlag
Jun 23, 2026
Merged

feat(sort): add flag for default updated_at sort on folders#3954
doubleface merged 1 commit into
masterfrom
feat/updatedAtDefaultSortFlag

Conversation

@doubleface

@doubleface doubleface commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

When drive.default-updated-at-sort.enabled is active, regular folders default to sorting by updated_at descending instead of name ascending.

The flag was already documented but not implemented

Summary by CodeRabbit

  • New Features
    • Expanded default folder sorting behavior to use update date as the default sort option in additional scenarios when a feature flag is enabled.

When drive.default-updated-at-sort.enabled is active, regular folders
default to sorting by updated_at descending instead of name ascending.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our agent can fix these. Install it.

Gates Passed
3 Quality Gates Passed

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 52d58c32-8cb0-4948-a40a-fedda063db48

📥 Commits

Reviewing files that changed from the base of the PR and between cc6e23d and 0e92f00.

📒 Files selected for processing (1)
  • src/hooks/useFolderSort/index.ts

Walkthrough

In useFolderSort, the condition that selects SORT_BY_UPDATE_DATE as the defaultSort value is extended. Previously, this sort was applied only when the current folder was TRASH_DIR_ID or RECENT_FOLDER_ID. The condition now also triggers when the feature flag drive.default-updated-at-sort.enabled is enabled, causing all folders to default to update-date sorting when that flag is active.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: adding a feature flag to enable default sorting by updated_at on folders. It is specific, concise, and directly reflects the primary objective of the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/updatedAtDefaultSortFlag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bundlemon

bundlemon Bot commented Jun 23, 2026

Copy link
Copy Markdown

BundleMon

Files updated (2)
Status Path Size Limits
static/js/main.(hash).js
48.87KB (+18B +0.04%) -
static/js/public.(hash).js
19.78KB (+16B +0.08%) -
Unchanged files (18)
Status Path Size Limits
static/js/cozy.(hash).js
928.36KB -
static/resource/(hash).js
336.09KB -
services/qualificationMigration.js
283.39KB -
services/dacc.js
263.13KB -
static/js/lib-react.(hash).js
43.88KB -
static/css/cozy.(hash).css
30.13KB -
static/js/lib-polyfill.(hash).js
22.77KB -
static/js/lib-router.(hash).js
21.86KB -
static/css/main.(hash).css
13.57KB -
static/js/intents.(hash).js
8.99KB -
static/js/(chunkId).(hash).js
8.6KB -
static/js/async/(chunkId).(hash).js
7.5KB -
manifest.webapp
3.09KB -
static/css/public.(hash).css
2.34KB -
index.html
770B -
public/index.html
706B -
intents/index.html
643B -
assets/manifest.json
185B -

Total files change +31B 0%

Groups updated (1)
Status Path Size Limits
**/*.js
5.98MB (+34B 0%) -
Unchanged groups (2)
Status Path Size Limits
**/*.{png,svg,ico}
2.16MB -
**/*.css
77.43KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@doubleface doubleface merged commit 9f495cc into master Jun 23, 2026
6 checks passed
@doubleface doubleface deleted the feat/updatedAtDefaultSortFlag branch June 23, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants