Skip to content

feat: gate eu-dss verify behind its own flag#3949

Merged
Crash-- merged 1 commit into
masterfrom
feat/split-eudss-sign-verify-flags
Jun 22, 2026
Merged

feat: gate eu-dss verify behind its own flag#3949
Crash-- merged 1 commit into
masterfrom
feat/split-eudss-sign-verify-flags

Conversation

@Crash--

@Crash-- Crash-- commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Move the eu-dss verify action to its own drive.verify.enabled flag, leaving the sign action on drive.sign.enabled, so verification and signature can be toggled independently.
  • Declare drive.verify.enabled in the flags switcher list.

Summary by CodeRabbit

  • New Features
    • Verification functionality is now controlled via dedicated feature flag for improved control and rollout management.

Verify and sign were both gated by drive.sign.enabled. Move the verify
action to drive.verify.enabled so verification and signature can be
toggled independently.
@Crash-- Crash-- force-pushed the feat/split-eudss-sign-verify-flags branch from 10c734b to a32d4c3 Compare June 22, 2026 14:29
codescene-delta-analysis[bot]

This comment was marked as outdated.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 33265a1a-1bf9-4b42-95ff-3e3a63514f4c

📥 Commits

Reviewing files that changed from the base of the PR and between 25697e1 and a32d4c3.

📒 Files selected for processing (2)
  • src/lib/flags.js
  • src/modules/actions/verifyWithEuDss.jsx

Walkthrough

The drive.verify.enabled feature flag is registered in flagsList() within src/lib/flags.js. In src/modules/actions/verifyWithEuDss.jsx, the displayCondition function is updated to check flag('drive.verify.enabled') instead of the previously used flag('drive.sign.enabled'), decoupling the verify action's visibility from the sign flag.

Possibly related PRs

  • linagora/twake-drive#3943: Introduced the verifyWithEuDss action and originally gated it on drive.sign.enabled, which is exactly the flag being replaced by this PR.

Suggested reviewers

  • lethemanh
  • rezk2ll
  • doubleface
  • zatteo
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/split-eudss-sign-verify-flags

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bundlemon

bundlemon Bot commented Jun 22, 2026

Copy link
Copy Markdown

BundleMon

Files updated (1)
Status Path Size Limits
static/js/main.(hash).js
48.85KB (+13B +0.03%) -
Unchanged files (19)
Status Path Size Limits
static/js/cozy.(hash).js
928.36KB -
static/resource/(hash).js
336.09KB -
services/qualificationMigration.js
283.39KB -
services/dacc.js
263.13KB -
static/js/lib-react.(hash).js
43.88KB -
static/css/cozy.(hash).css
30.13KB -
static/js/lib-polyfill.(hash).js
22.77KB -
static/js/lib-router.(hash).js
21.86KB -
static/js/public.(hash).js
19.77KB -
static/css/main.(hash).css
13.57KB -
static/js/intents.(hash).js
8.99KB -
static/js/(chunkId).(hash).js
8.6KB -
static/js/async/(chunkId).(hash).js
7.5KB -
manifest.webapp
3.09KB -
static/css/public.(hash).css
2.34KB -
index.html
772B -
public/index.html
706B -
intents/index.html
642B -
assets/manifest.json
185B -

Total files change +14B 0%

Groups updated (1)
Status Path Size Limits
**/*.js
5.98MB (+13B 0%) -
Unchanged groups (2)
Status Path Size Limits
**/*.{png,svg,ico}
2.16MB -
**/*.css
77.43KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@Crash-- Crash-- merged commit 3238597 into master Jun 22, 2026
6 of 7 checks passed
@Crash-- Crash-- deleted the feat/split-eudss-sign-verify-flags branch June 22, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant