Skip to content

fix(sharings): keep the path label from clipping under a short name#3945

Merged
rezk2ll merged 1 commit into
masterfrom
fix/sharings-path-label-clipped
Jun 22, 2026
Merged

fix(sharings): keep the path label from clipping under a short name#3945
rezk2ll merged 1 commit into
masterfrom
fix/sharings-path-label-clipped

Conversation

@rezk2ll

@rezk2ll rezk2ll commented Jun 22, 2026

Copy link
Copy Markdown
Member

Problem

In the sharings list, the /sharings link shown under a shared drive's name gets clipped when the name is shorter than the link text (a one-letter share showed /s instead of /sharings). cozy-ui's Filename stacks the name and the path label in a column that shrinks to the name's width, so a path wider than a short name is cut off.

Solution

Let that column fill the name cell when a path is shown, so the path label uses the available width instead of being capped to the name. Long paths still truncate at the cell edge.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file list display to prevent path information from being clipped when displaying filenames alongside paths. The filename cell now properly utilizes available space to ensure all information remains visible without truncation.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 30ab6324-30ab-4569-bc55-0ef2246f3aa3

📥 Commits

Reviewing files that changed from the base of the PR and between 673d628 and 27b49e5.

📒 Files selected for processing (2)
  • src/modules/filelist/virtualized/cells/FileName.jsx
  • src/styles/filelist.styl

Walkthrough

In FileName.jsx, the outer <span> wrapping the file name now conditionally receives the CSS class fil-file-name-with-path when hidePath is false. A new .fil-file-name-with-path class is added to filelist.styl that sets width: 100%, ensuring the name cell fills available space and prevents the adjacent path label from being clipped when the filename is short.

Possibly related PRs

  • linagora/twake-drive#3916: Modifies filelist.styl to add .fil-file-path constraining the path link width, directly related to the same name/path cell layout being adjusted here.

Suggested reviewers

  • JF-Cozy
  • zatteo
  • lethemanh
  • doubleface
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main fix: preventing path label clipping under short filenames, which matches the core objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sharings-path-label-clipped

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@bundlemon

bundlemon Bot commented Jun 22, 2026

Copy link
Copy Markdown

BundleMon

Files updated (1)
Status Path Size Limits
static/js/intents.(hash).js
8.99KB (+28B +0.31%) -
Unchanged files (19)
Status Path Size Limits
static/js/cozy.(hash).js
928.37KB -
static/resource/(hash).js
336.09KB -
services/qualificationMigration.js
283.39KB -
services/dacc.js
263.13KB -
static/js/main.(hash).js
48.79KB -
static/js/lib-react.(hash).js
43.88KB -
static/css/cozy.(hash).css
30.13KB -
static/js/lib-polyfill.(hash).js
22.77KB -
static/js/lib-router.(hash).js
21.86KB -
static/js/public.(hash).js
19.77KB -
static/css/main.(hash).css
13.57KB -
static/js/(chunkId).(hash).js
8.6KB -
static/js/async/(chunkId).(hash).js
7.5KB -
manifest.webapp
3.09KB -
static/css/public.(hash).css
2.34KB -
index.html
771B -
public/index.html
705B -
intents/index.html
642B -
assets/manifest.json
185B -

Total files change +28B 0%

Groups updated (2)
Status Path Size Limits
**/*.js
5.98MB (+71B 0%) -
**/*.css
77.43KB (+12B +0.02%) -
Unchanged groups (1)
Status Path Size Limits
**/*.{png,svg,ico}
2.16MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@rezk2ll rezk2ll enabled auto-merge (rebase) June 22, 2026 09:16
return (
<span title={infected ? t('antivirus.infectedFile') : title}>
<span
className={hidePath ? undefined : styles['fil-file-name-with-path']}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need stylus file for that: you have .u-w-100 class

@rezk2ll rezk2ll merged commit 5dbf8ae into master Jun 22, 2026
6 checks passed
@rezk2ll rezk2ll deleted the fix/sharings-path-label-clipped branch June 22, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants