fix: report a failed dataproxy recents query instead of hiding it#3936
Conversation
The dataproxy recents failure was logged at warn level and swallowed, so it never surfaced in Sentry. Log it with logger.error (which the app's Sentry config records) while keeping the local-query fallback.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughIn 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Gates Passed
3 Quality Gates Passed
See analysis details in CodeScene
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
BundleMonUnchanged files (20)
Total files change +2B 0% Unchanged groups (3)
Final result: ✅ View report in BundleMon website ➡️ |
Problem
When the dataproxy recents query fails, the error was logged at
warnand swallowed, so it never reached Sentry and we had no visibility into it (the view silently falls back to the local query).Solution
Log the failure with
logger.error, which the app's Sentry config records, while keeping the local-query fallback. Matches how the rest of the app reports errors.Summary by CodeRabbit