Skip to content

fix(locales): Remove one wrong sentence#3935

Merged
doubleface merged 1 commit into
masterfrom
fix/moveOutsideSharingLocales
Jun 19, 2026
Merged

fix(locales): Remove one wrong sentence#3935
doubleface merged 1 commit into
masterfrom
fix/moveOutsideSharingLocales

Conversation

@doubleface

@doubleface doubleface commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

https://app.notion.com/p/linagora/Change-wording-when-I-move-a-file-outside-a-sharing-38262718bad180219f6fd950f13475b4?source=copy_link

Summary by CodeRabbit

  • Documentation
    • Updated warning message text across multiple languages (English, French, Russian, Vietnamese) when removing items from shared folders. The message now clearly indicates items will be removed from shared access.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a650f27e-9319-462e-913b-e554acf5cf03

📥 Commits

Reviewing files that changed from the base of the PR and between 1600705 and b71d26f.

📒 Files selected for processing (4)
  • src/locales/en.json
  • src/locales/fr.json
  • src/locales/ru.json
  • src/locales/vi.json

Walkthrough

The Move.outsideSharedFolder.content_2 localization key is updated in four locale files: en.json, fr.json, ru.json, and vi.json. In each file, the existing message is shortened by removing the clause that stated moved items would be placed in the trash for all members of the share. The remaining text retains the warning that the item(s) will be removed from the shared folder, along with the existing %{type} and %{smart_count} placeholders and singular/plural variants.

Suggested reviewers

  • rezk2ll
  • zatteo
  • lethemanh
  • JF-Cozy
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(locales): Remove one wrong sentence' accurately describes the main change—a correction to localization strings by removing an incorrect sentence about items being trashed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/moveOutsideSharingLocales

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No application code in the PR — skipped Code Health checks.

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@bundlemon

bundlemon Bot commented Jun 18, 2026

Copy link
Copy Markdown

BundleMon

Unchanged files (20)
Status Path Size Limits
static/js/cozy.(hash).js
928.17KB -
static/resource/(hash).js
336.09KB -
services/qualificationMigration.js
283.39KB -
services/dacc.js
263.13KB -
static/js/main.(hash).js
48.12KB -
static/js/lib-react.(hash).js
43.88KB -
static/css/cozy.(hash).css
30.13KB -
static/js/lib-polyfill.(hash).js
22.77KB -
static/js/lib-router.(hash).js
21.86KB -
static/js/public.(hash).js
19.79KB -
static/css/main.(hash).css
13.57KB -
static/js/intents.(hash).js
9.2KB -
static/js/(chunkId).(hash).js
8.6KB -
manifest.webapp
3.09KB -
static/css/public.(hash).css
2.34KB -
static/js/async/(chunkId).(hash).js
2.06KB -
main/index.html
769B -
public/index.html
704B -
intents/index.html
643B -
assets/manifest.json
185B -

Total files change -3B 0%

Groups updated (1)
Status Path Size Limits
**/*.js
5.98MB (-228B 0%) -
Unchanged groups (2)
Status Path Size Limits
**/*.{png,svg,ico}
2.16MB -
**/*.css
77.42KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@doubleface doubleface enabled auto-merge (rebase) June 19, 2026 07:14
@doubleface doubleface merged commit a6ab385 into master Jun 19, 2026
6 checks passed
@doubleface doubleface deleted the fix/moveOutsideSharingLocales branch June 19, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants