Skip to content

fix(sharings): show share action for received shared folders#3922

Merged
doubleface merged 1 commit into
masterfrom
fix/shareActionOnSharedFolderRecipient
Jun 16, 2026
Merged

fix(sharings): show share action for received shared folders#3922
doubleface merged 1 commit into
masterfrom
fix/shareActionOnSharedFolderRecipient

Conversation

@doubleface

@doubleface doubleface commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

https://app.notion.com/p/linagora/missing-share-action-38062718bad180a5b59ffe9469ec7d2f

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Updated visibility conditions for the "Share" action on shared drives. The action now appears for additional shared drive scenarios, including received shared drives.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@bundlemon

bundlemon Bot commented Jun 16, 2026

Copy link
Copy Markdown

BundleMon

Files updated (1)
Status Path Size Limits
static/js/main.(hash).js
47.63KB (+23B +0.05%) -
Unchanged files (19)
Status Path Size Limits
static/js/cozy.(hash).js
928.62KB -
static/resource/(hash).js
336.09KB -
services/qualificationMigration.js
282.66KB -
services/dacc.js
262.48KB -
static/js/lib-react.(hash).js
43.88KB -
static/css/cozy.(hash).css
31.42KB -
static/js/lib-polyfill.(hash).js
22.77KB -
static/js/lib-router.(hash).js
21.86KB -
static/js/public.(hash).js
19.48KB -
static/css/main.(hash).css
13.57KB -
static/js/intents.(hash).js
9.2KB -
static/js/(chunkId).(hash).js
8.6KB -
manifest.webapp
3.09KB -
static/css/public.(hash).css
2.34KB -
static/js/async/(chunkId).(hash).js
2.06KB -
main/index.html
769B -
public/index.html
704B -
intents/index.html
644B -
assets/manifest.json
185B -

Total files change +20B 0%

Groups updated (1)
Status Path Size Limits
**/*.js
5.98MB (+23B 0%) -
Unchanged groups (2)
Status Path Size Limits
**/*.{png,svg,ico}
2.16MB -
**/*.css
78.72KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5945f9d2-8f84-4dbd-9be6-7396f93c6b47

📥 Commits

Reviewing files that changed from the base of the PR and between 6677402 and 6e1a27f.

📒 Files selected for processing (2)
  • src/modules/shareddrives/components/actions/shareSharedDrive.js
  • src/modules/shareddrives/components/actions/shareSharedDrive.spec.js

Walkthrough

The shareSharedDrive function has its isOwner parameter removed from the destructured argument list. The displayCondition no longer calls isOwner?.(doc._id) to gate visibility; it now shows the action for any shared-drive doc that is not a file-root shared drive. The test file updates the makeAction helper to optionally accept isOwner and pathname without a default, removes the isOwner column from the parameterized display-condition test matrix, adds a dedicated test asserting the action is shown when isOwner returns false, and adjusts the multi-selection test to use the updated helper.

Possibly related PRs

  • linagora/twake-drive#3909: Modifies shareSharedDrive.js by changing the function signature to add pathname and updating navigation logic via makeFileSharePath, directly preceding the current removal of isOwner.

Suggested reviewers

  • JF-Cozy
  • zatteo
  • lethemanh
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(sharings): show share action for received shared folders' accurately describes the main change—removing the isOwner check to allow the share action to be displayed for received shared folders.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/shareActionOnSharedFolderRecipient

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@doubleface doubleface added the e2e Run the E2E suite on this PR label Jun 16, 2026
@doubleface doubleface merged commit b456584 into master Jun 16, 2026
7 checks passed
@doubleface doubleface deleted the fix/shareActionOnSharedFolderRecipient branch June 16, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Run the E2E suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants