fix(excalidraw): load public async chunks from the same origin#3880
Conversation
@excalidraw/excalidraw code-splits browser-fs-access, its locale bundles and a canvas polyfill as webpack async chunks loaded from __webpack_public_path__. In the public build that path points at the cross-origin main dev server, so the chunks fail to load and the editor cannot fetch its locale or open and save files. Point the public build at its own origin. In production it already resolves there, so this only changes dev behaviour.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis pull request updates Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Our agent can fix these. Install it.
Gates Passed
3 Quality Gates Passed
Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
BundleMonFiles updated (2)
Unchanged files (19)
Total files change +46B 0% Groups updated (1)
Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
Summary
__webpack_public_path__to the public build path insetupAssetPath.jsso Excalidraw's webpack async chunks (browser-fs-access, locales, canvas polyfill) load same-origin.Summary by CodeRabbit
/publicshare build to ensure proper same-origin resolution.