Skip to content

chore(excalidraw): drop the bundled xiaolai cjk font#3879

Merged
Crash-- merged 1 commit into
masterfrom
chore/excalidraw-drop-xiaolai-font
Jun 5, 2026
Merged

chore(excalidraw): drop the bundled xiaolai cjk font#3879
Crash-- merged 1 commit into
masterfrom
chore/excalidraw-drop-xiaolai-font

Conversation

@Crash--

@Crash-- Crash-- commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Exclude Excalidraw's Xiaolai CJK font from the rsbuild font copy.
  • It is ~12 MB of incompressible woff2 per build (two copies) and only renders CJK glyphs, so it pushes the published tarball over the registry size limit for no benefit here.

Summary by CodeRabbit

  • Chores
    • Updated font asset configuration to exclude the Xiaolai font set from the build while preserving existing font directory structure and pre-minified assets.

Excalidraw ships Xiaolai, its CJK fallback font, as ~12 MB of woff2
subsets per build. woff2 does not compress, so the two build copies
add ~24 MB of incompressible weight to the published tarball and push
it over the registry size limit. Drawings do not render CJK glyphs
here, so exclude it from the rsbuild font copy.
@coderabbitai

coderabbitai Bot commented Jun 5, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bd04116a-c584-4443-80ed-361eae0ebd48

📥 Commits

Reviewing files that changed from the base of the PR and between 9b3cb50 and e9fc109.

📒 Files selected for processing (1)
  • rsbuild.config.mjs

Walkthrough

This PR updates the Excalidraw asset bundling configuration in rsbuild.config.mjs to exclude the Xiaolai CJK fallback font subset. An explanatory comment clarifies that this exclusion reduces bundle size and helps stay within the registry limit. The implementation adds a globOptions.ignore pattern for **/Xiaolai/** to the existing asset copy rule while preserving the rest of the font bundling behavior.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/excalidraw-drop-xiaolai-font

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codescene-delta-analysis codescene-delta-analysis Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Quality Gate Profile: The Bare Minimum
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@Crash-- Crash-- merged commit 22b56a2 into master Jun 5, 2026
3 of 4 checks passed
@Crash-- Crash-- deleted the chore/excalidraw-drop-xiaolai-font branch June 5, 2026 16:00
@bundlemon

bundlemon Bot commented Jun 5, 2026

Copy link
Copy Markdown

BundleMon

Unchanged files (21)
Status Path Size Limits
static/js/(chunkId).(hash).js
1.49MB -
public/static/js/(chunkId).(hash).js
1.4MB -
static/js/cozy.(hash).js
918.01KB -
public/static/js/cozy.(hash).js
778.4KB -
(hash).js
336.11KB -
public/(hash).js
336.11KB -
services/qualificationMigration.js
283.16KB -
services/dacc.js
262.9KB -
static/js/main.(hash).js
172.27KB -
public/static/js/public.(hash).js
147.22KB -
public/static/js/lib-react.(hash).js
43.88KB -
static/js/lib-react.(hash).js
43.88KB -
public/static/css/cozy.(hash).css
31.36KB -
static/css/cozy.(hash).css
31.36KB -
public/static/js/lib-router.(hash).js
21.86KB -
static/js/lib-router.(hash).js
21.86KB -
static/css/main.(hash).css
11.03KB -
public/static/css/public.(hash).css
6.74KB -
manifest.webapp
3.08KB -
index.html
716B -
assets/manifest.json
185B -

No change in files bundle size

Unchanged groups (3)
Status Path Size Limits
**/*.js
12.16MB -
**/*.{png,svg,ico}
2.19MB -
**/*.css
163.15KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant