Orphan UTXO filter and limit

[darioAnongba]

• Filter out orphan UTXOs with missing signing information: In prior versions, we didn't store KeyFamily and KeyIndex for orphan UTXOs. When both values are 0, LND fails to sign the transaction. This PR filters out these UTXOs to prevent signing failures.

• Limit the number of orphan UTXOs fetched: Previously, there was no limit on how many orphan UTXOs could be included in a transaction. If too many were fetched, the transaction could become too large. This PR adds a limit of 20 orphan UTXOs per transaction (MaxOrphanUTXOs).

• Enable wallet.sweep-orphan-utxos by default: Changed the default from false to true. This ensures tombstone and burn outputs are automatically swept during onchain transactions.

[gemini-code-assist]

Summary of Changes

Hello @darioAnongba, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and usability of orphan UTXO management. It addresses potential transaction signing failures by filtering out improperly stored UTXOs and prevents transaction bloat by limiting the number of swept UTXOs. Furthermore, it streamlines the process by enabling automatic orphan UTXO sweeping by default, ensuring a cleaner and more efficient wallet operation.

Highlights

• Orphan UTXO Filtering: Implemented filtering to exclude orphan UTXOs that lack necessary signing information (where both KeyFamily and KeyIndex are 0). This prevents LND from failing to sign transactions due to these malformed UTXOs, which were created in prior versions.
• Orphan UTXO Limit: Introduced a limit of 20 (MaxOrphanUTXOs) on the number of orphan UTXOs fetched for sweeping. This prevents transactions from becoming excessively large when many orphan UTXOs are present.
• Default Sweeping Enabled: The wallet.sweep-orphan-utxos configuration option is now enabled by default. This ensures that tombstone and burn outputs are automatically swept during on-chain transactions, improving wallet hygiene.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces several improvements to orphan UTXO sweeping, including filtering out UTXOs with missing signing information, limiting the number of UTXOs fetched, and enabling sweeping by default. The changes are logical and well-implemented, and the new functionality is covered by tests. I have a few suggestions to improve the new tests and align the logging with the repository's style guide.

[coveralls]

Pull Request Test Coverage Report for Build 20035562459

Details

• 10 of 13 (76.92%) changed or added relevant lines in 3 files are covered.
• 8293 unchanged lines in 122 files lost coverage.
• Overall coverage decreased (-0.006%) to 56.64%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
tapdb/assets_store.go	6	9	66.67%

Files with Coverage Reduction	New Missed Lines	%
authmailbox/client.go	2	66.67%
commitment/proof.go	2	87.29%
fn/retry.go	2	92.5%
tapdb/interfaces.go	2	78.33%
universe/interface.go	3	74.21%
commitment/encoding.go	4	68.75%
mssmt/encoding.go	4	76.67%
rpcutils/price_oracle_marshal.go	4	85.07%
tapdb/sqlc/transfers.sql.go	4	82.65%
tapsend/proof.go	4	85.99%

Totals
Change from base Build 20033169882:	-0.006%
Covered Lines:	64885
Relevant Lines:	114557

---

💛 - Coveralls

[jtobin]

(Nit: I would avoid long lines in commit messages, e.g. in 4539224.)

LGTM. 👍 👍

[GeorgeTsagk]

cACK, approach looks good, will take a look at the test in a while before approving

[GeorgeTsagk]

LGTM

have some suggestions to extend the tests, otherwise looking good 🟢