Skip to content

Conversation

@guggero
Copy link
Contributor

@guggero guggero commented Jul 31, 2025

Depends on btcsuite/btcwallet#1022 and then lightningnetwork/lnd#10119 which will hopefully make it into lnd v0.19.3-beta.

Created this itest to reproduce lightninglabs/lightning-terminal#1123.
Further investigation then lead to the creation of this bug report issue: lightningnetwork/lnd#10120

So this test will not succeed until lightningnetwork/lnd#10120 is fixed. But putting up the PR as a draft as we should aim to fix that issue and then have these tests run in the CI by default.

@coveralls
Copy link

coveralls commented Jul 31, 2025

Pull Request Test Coverage Report for Build 19930111150

Details

  • 11 of 45 (24.44%) changed or added relevant lines in 2 files are covered.
  • 69 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.005%) to 56.619%

Changes Missing Coverage Covered Lines Changed/Added Lines %
itest/test_harness.go 5 39 12.82%
Files with Coverage Reduction New Missed Lines %
fn/context_guard.go 1 91.94%
commitment/tap.go 2 85.42%
tapchannel/aux_leaf_signer.go 2 43.18%
tapdb/mssmt.go 2 91.36%
tapdb/sqlc/transfers.sql.go 2 83.33%
tapdb/sqlc/universe.sql.go 2 73.71%
universe/syncer.go 2 85.93%
universe/archive.go 3 81.74%
asset/asset.go 4 80.7%
mssmt/compacted_tree.go 4 78.57%
Totals Coverage Status
Change from base Build 19928906227: -0.005%
Covered Lines: 64867
Relevant Lines: 114567

💛 - Coveralls

@levmi levmi moved this from 🆕 New to 👀 In review in Taproot-Assets Project Board Jul 31, 2025
@levmi levmi moved this from 👀 In review to 🏗 In progress in Taproot-Assets Project Board Jul 31, 2025
@guggero guggero force-pushed the itest-remote-signer branch 2 times, most recently from e62df0f to f200946 Compare August 7, 2025 07:26
@guggero guggero marked this pull request as ready for review August 7, 2025 07:30
@guggero
Copy link
Contributor Author

guggero commented Aug 7, 2025

With lnd v0.19.3-beta.rc1 out, this is now out of draft.

@guggero guggero requested review from GeorgeTsagk and ffranr August 7, 2025 07:30
@guggero guggero moved this from 🏗 In progress to 👀 In review in Taproot-Assets Project Board Aug 7, 2025
@guggero guggero force-pushed the itest-remote-signer branch 3 times, most recently from f1b456f to 1e4f9ea Compare August 21, 2025 07:25
@guggero guggero requested review from jtobin and removed request for ffranr August 21, 2025 07:25
Copy link
Member

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍

@guggero guggero force-pushed the itest-remote-signer branch from 1e4f9ea to 1e2cb4a Compare August 21, 2025 15:35
@jtobin jtobin force-pushed the itest-remote-signer branch from 1e2cb4a to 1da61fd Compare December 4, 2025 10:31
@jtobin
Copy link
Member

jtobin commented Dec 4, 2025

I've rebased this, as it seems easy enough to resurrect and review otherwise. Unsure we actually want to run w/remote signing mode in CI, though.

@jtobin jtobin force-pushed the itest-remote-signer branch from 1da61fd to e45ed66 Compare December 4, 2025 13:06
This commit adds a new flag to the integration test suite that starts
the single lnd node (alice) either in normal or in remote-signing mode.
In remote-signing mode, alice is actually a watch-only node that is
connected to a seconardy signer node over RPC.
To make sure `tapd` works when the connected `lnd` node is running in
remote-signing mode, we add a new CI target that runs all integration
tests in that mode.
@jtobin jtobin force-pushed the itest-remote-signer branch from e45ed66 to 0fec22a Compare December 4, 2025 13:10
@lightninglabs-deploy
Copy link

@guggero, remember to re-request review from reviewers when ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

6 participants