Add option to stop creation of macaroons #272
Conversation
orbitalturtle
force-pushed
the
macaroon-hex
branch
2 times, most recently
from
31e0c1e to
1635bdb
Compare
orbitalturtle
force-pushed
the
macaroon-hex
branch
2 times, most recently
from
dddb677 to
b4c7a0d
Compare
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Definitely looks better this way.
orbitalturtle
force-pushed
the
macaroon-hex
branch
3 times, most recently
from
ba9aa48 to
e5e19f5
Compare
|
Thanks for the review @guggero ! Made those changes. |
orbitalturtle
changed the title
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
LGTM pending the dependent PRs in lndclient and lnd.
The lnd PR is very close and can be merged as soon as the three remaining issues are addressed. Then we can update the lndclient and this PR to use the actual versions in go.mod.
orbitalturtle
force-pushed
the
macaroon-hex
branch
3 times, most recently
from
09dc898 to
e6507b5
Compare
|
@guggero great, I updated lnd and lndclient with the actual versions. I also attempted to take care of all the changes required to bump those up... I'm especially not sure if I updated macaroons.NewService method correctly. |
|
@orbitalturtle I forgot to mention this to you, sorry. There is a branch I pushed to the main Pool repo called |
…rminal Export AllPermissions slice so that we can retrieve the permissions required to run Pool's operations. We need these permissions in Lightning Terminal in order to bake a super macaroon that allows access to Pool.
orbitalturtle
force-pushed
the
macaroon-hex
branch
from
e6507b5 to
aabb781
Compare
orbitalturtle
force-pushed
the
macaroon-hex
branch
2 times, most recently
from
fb3c269 to
7584bd9
Compare
|
@guggero Got it, no problem, Just updated. |
| } | ||
|
|
||
| // Start the macaroon service and let it create its default macaroon in | ||
| // case it doesn't exist yet. |
There was a problem hiding this comment.
This comment gets outdated after noMacaroonCreation is set to false.
| }() | ||
|
|
||
| // Start the macaroon service and let it create its default macaroon in | ||
| // case it doesn't exist yet. |
There was a problem hiding this comment.
nit: change the comment so it reflects that it creates its default macaroon in case it doesn't exist yet and noMacaroonCreation is true
|
Can be rebased onto master now. Sorry for the indirect/unintended close. |
|
I'm going to take over those PRs so they can hopefully make it into the lnd 0.14.0 release of LiT. I hope you don't mind! |
3 participants
When using the Lightning Terminal in stateless integrated mode (described here: lightninglabs/lightning-terminal#160), Pool shouldn't create a new macaroon. This is a small change to add an option to stop macaroons from being created.
Also exports the AllPermissions slice to make baking a macaroon with Pool's permissions easier in Lightning Terminal's integrated mode.