signer_client: correctly use 32-byte key for schnorr #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was incorrect all along, seems like we haven't actually used the VerifySchnorr option in any project yet.
bhandras
approved these changes
Jun 2, 2025
GeorgeTsagk
approved these changes
Jun 2, 2025
| // If the signature is a Schnorr signature, we need to set the public | ||
| // key as the 32-byte x-only key, as mentioned in the RPC docs. | ||
| if rpcIn.IsSchnorrSig { | ||
| rpcIn.Pubkey = pubkey[1:] |
Member
There was a problem hiding this comment.
could also check for the len(pubkey) here to avoid a potential panic?
Member
There was a problem hiding this comment.
i dont think it can panic. The param is [33]byte and so is guaranteed to have 33 bytes
ellemouton
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was incorrect all along, seems like we haven't actually used the
VerifySchnorr()option in any project yet.This is needed for lightninglabs/taproot-assets#1502.
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.