Custom channels liquidity edge case: AddInvoice with existing route hints #1106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeTsagk
force-pushed
the
custom-chans-existing-routehints
branch
from
6221457 to
396bed5
Compare
Member
Author
|
This PR didn't get merged on time when the tapd counterpart got merged: lightninglabs/taproot-assets#1627 Rebased on |
GeorgeTsagk
force-pushed
the
custom-chans-existing-routehints
branch
from
396bed5 to
2fe7d87
Compare
guggero
approved these changes
Aug 4, 2025
Contributor
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Thanks, LGTM 🎉
I've increased the linter timeout in the tapd-main-branch branch. If you rebase the failures should go away.
GeorgeTsagk
force-pushed
the
custom-chans-existing-routehints
branch
from
2fe7d87 to
c58b6d3
Compare
Member
Author
|
Rebased |
guggero
force-pushed
the
tapd-main-branch
branch
from
d59f943 to
4c6c117
Compare
GeorgeTsagk
force-pushed
the
tapd-main-branch
branch
from
4c6c117 to
f76ce2f
Compare
ffranr
reviewed
Sep 16, 2025
Contributor
ffranr
left a comment
ffranr
left a comment
There was a problem hiding this comment.
I think this needs a rebase. Seems to include a merge commit also.
GeorgeTsagk
force-pushed
the
custom-chans-existing-routehints
branch
from
c58b6d3 to
c82490a
Compare
GeorgeTsagk
added
the
no-changelog
|
@ffranr: review reminder |
GeorgeTsagk
force-pushed
the
tapd-main-branch
branch
from
f76ce2f to
712847f
Compare
GeorgeTsagk
force-pushed
the
custom-chans-existing-routehints
branch
from
c82490a to
9182472
Compare
ffranr
requested changes
Sep 25, 2025
This commit mainly changes the returned type of the payment result for asset payments. We create a struct TapPaymentResult which contains all the related information for the outcome of an asset payment.
GeorgeTsagk
force-pushed
the
custom-chans-existing-routehints
branch
from
9182472 to
bf4d46b
Compare
ffranr
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new edge case to the custom channels test suite, where we call the
taprpc.AddInvoicewith existing route hints, which include a valid accepted quote.Related tapd PR: lightninglabs/taproot-assets#1627