Define blip-0032, DNSSEC proof querying over onion messages#32
Merged
TheBlueMatt merged 1 commit intolightning:masterfrom Jun 3, 2024
Merged
Conversation
dfd60a9 to
9f108e4
Compare
9f108e4 to
7eb227a
Compare
t-bast
reviewed
Feb 12, 2024
22 tasks
adam2k
reviewed
Feb 26, 2024
adam2k
reviewed
Feb 26, 2024
Contributor
Author
|
I intend to merge it in a week or two if no objections/further feedback are raised. |
Contributor
|
Sounds good, there are still question around the encoding of some of the fields, but we can merge a first version and update it with what makes the most sense when an implementation is ready. |
Contributor
Author
|
Oh shit right, I intended to rewrite this to not have the weird omrequest thing, I've now rewritten this and think its ready to go (but will squash the commits before landing). |
t-bast
reviewed
May 31, 2024
Contributor
t-bast
left a comment
There was a problem hiding this comment.
One small inconsistency with the feature name, otherwise it looks good to me.
ca3e516 to
af0b621
Compare
Contributor
Author
|
Squashed and fixed the typo: $ git diff-tree -U1 ca3e516 af0b621
diff --git a/blip-0032.md b/blip-0032.md
index bb7ecff..03782e0 100644
--- a/blip-0032.md
+++ b/blip-0032.md
@@ -35,3 +35,3 @@ Two new onion messages are defined, `dnssec_query` and `dnssec_proof`.
Nodes which accept and reply to `dnssec_query`-containing onion messages from any sender:
- * SHOULD set the `dns_query` feature flag in their `node_announcement`.
+ * SHOULD set the `dns_resolver` feature flag in their `node_announcement`. |
Contributor
Author
|
I intend to merge this next week unless there is further feedback. |
t-bast
approved these changes
Jun 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.