Skip to content

Include .gitignore #80#97

Merged
ignasi35 merged 2 commits intolightbend:mainfrom
ignasi35:80-generate-gitignore
Jul 5, 2021
Merged

Include .gitignore #80#97
ignasi35 merged 2 commits intolightbend:mainfrom
ignasi35:80-generate-gitignore

Conversation

@ignasi35
Copy link
Copy Markdown
Contributor

@ignasi35 ignasi35 commented Jul 2, 2021

This is two-step problem.

Following the SO link @ennru provided, I managed to have .gitignore in target/classes/archetype-resources. But, the .gitignore is not listed in target/META-INF/maven/archetype-metadata.xml and it doesn't end up in the jar file.

So, we must:

  • tune the maven-resources-plugin
  • something else (been trying several things and didn't find what...)

@ignasi35
Copy link
Copy Markdown
Contributor Author

ignasi35 commented Jul 5, 2021

something else (been trying several things and didn't find what...)

Turns out archetype-metada.xml is not generated but manually maintained. Adding .gitignore on the appropriate places made the trick.

You can try this locally:

cd maven-java/
mvn clean install
mkdir temp
cd temp
mvn archetype:generate -Dfilter=com.akkaserverless:akkaserverless-maven-archetype -DartifactId=my-proj -DgroupId=fakke
cat my-proj/.gitignore

@ignasi35 ignasi35 self-assigned this Jul 5, 2021
@ignasi35 ignasi35 marked this pull request as ready for review July 5, 2021 08:27
@ignasi35 ignasi35 requested a review from huntc July 5, 2021 09:38
Copy link
Copy Markdown
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ignasi35 ignasi35 merged commit 53dfa34 into lightbend:main Jul 5, 2021
@ignasi35 ignasi35 deleted the 80-generate-gitignore branch July 5, 2021 10:11
@ennru ennru mentioned this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants