build publish maven plugin from CI to sonatype#65
Merged
octonato merged 38 commits intorgc/feature-branch-maven-javafrom Jun 25, 2021
Merged
build publish maven plugin from CI to sonatype#65octonato merged 38 commits intorgc/feature-branch-maven-javafrom
octonato merged 38 commits intorgc/feature-branch-maven-javafrom
Conversation
7982bd2 to
cb284c5
Compare
So we only have to do it when publishing
raboof
commented
Jun 24, 2021
| <configuration> | ||
| <serverId>ossrh</serverId> | ||
| <nexusUrl>https://s01.oss.sonatype.org</nexusUrl> | ||
| <autoReleaseAfterClose>false</autoReleaseAfterClose> |
Contributor
Author
There was a problem hiding this comment.
we could set this to 'true' eventually, but for the first release perhaps let's give ourselves a chance to check the artifacts?
octonato
approved these changes
Jun 24, 2021
| command: | | ||
| cd maven-java | ||
| echo $PGP_SECRET | base64 -d | gpg --import --batch | ||
| # It seems ~/.m2 is not actually restored from the cache? |
Member
There was a problem hiding this comment.
We need to investigate it further. We may be doing something wrong.
When I was bringing the maven code here, I was surprised to see that I have to call sbt publishM2 more then once in the same CI build. I was planning to call only once and reuse the local artifacts on the next jobs. Didn't work as expected.
Member
|
hmm, I could have squashed before merging. 🤦 |
This was referenced Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards #27