chore(codegen): split some utils in 'java' and 'scala' variants#615
Merged
raboof merged 1 commit intolightbend:mainfrom Oct 13, 2021
Merged
chore(codegen): split some utils in 'java' and 'scala' variants#615raboof merged 1 commit intolightbend:mainfrom
raboof merged 1 commit intolightbend:mainfrom
Conversation
Should also fix some errors on master due to parallel merges
johanandren
approved these changes
Oct 13, 2021
Contributor
johanandren
left a comment
johanandren
left a comment
There was a problem hiding this comment.
LGTM. this is exactly what I was arguing for with @octonato the other day.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should also fix some errors on master due to parallel merges