Rename 'Handler' to 'Router'#612
Merged
octonato merged 1 commit intolightbend:mainfrom Oct 13, 2021
Merged
Conversation
raboof
force-pushed
the
rename-handler-to-router
branch
from
668c6b8 to
fdd55ce
Compare
johanandren
approved these changes
Oct 13, 2021
Contributor
johanandren
left a comment
johanandren
left a comment
There was a problem hiding this comment.
LGTM
This will not break existing code since there is no user code interfacing with the Handler/Router right?
Contributor
Author
I think it's all "managed" generated code that refers to this, yeah |
raboof
force-pushed
the
rename-handler-to-router
branch
from
fdd55ce to
7e5c5ce
Compare
raboof
force-pushed
the
rename-handler-to-router
branch
from
7e5c5ce to
d13b0f8
Compare
octonato
approved these changes
Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547