chore: use more reasonable folders for generated managed Scala files#610
Merged
johanandren merged 2 commits intolightbend:mainfrom Oct 12, 2021
Merged
chore: use more reasonable folders for generated managed Scala files#610johanandren merged 2 commits intolightbend:mainfrom
johanandren merged 2 commits intolightbend:mainfrom
Conversation
jrudolph
force-pushed
the
fix-generation-folders
branch
from
ee6d77f to
737347a
Compare
jrudolph
commented
Oct 12, 2021
| "com.akkaserverless" %% "akkaserverless-scala-sdk-testkit" % AkkaServerlessSdkVersion % Test), | ||
| Compile / PB.targets += | ||
| gen( | ||
| akkaGrpcCodeGeneratorSettings.value :+ AkkaserverlessGenerator.enableDebug) -> (Compile / sourceManaged).value / "akkaserverless", |
Contributor
Author
There was a problem hiding this comment.
sourceManaged is already target/scala-2.13/src_managed/main/ so if we add another directory it will show as a package in IDEs.
jrudolph
commented
Oct 12, 2021
| Compile / temporaryUnmanagedDirectory := (Compile / baseDirectory).value / "target" / "akkaserverless-unmanaged", | ||
| Test / temporaryUnmanagedDirectory := (Test / baseDirectory).value / "target" / "akkaserverless-unmanaged-test", | ||
| akkaGrpcCodeGeneratorSettings.value :+ AkkaserverlessGenerator.enableDebug) -> (Compile / sourceManaged).value, | ||
| Compile / temporaryUnmanagedDirectory := (Compile / crossTarget).value / "akkaserverless-unmanaged", |
Contributor
Author
There was a problem hiding this comment.
Avoids hardcoding target in cases target has been redefined (which I use often to create more specific targets for different branches or JVM versions etc).
raboof
approved these changes
Oct 12, 2021
Contributor
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
Good, the scripted test still checks for them in the old location though
Contributor
Author
Yes, just fixed that as well. |
johanandren
approved these changes
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.