Conversation
| // end::declarations[] | ||
| // tag::name[] | ||
| service CustomerByName { | ||
|
|
There was a problem hiding this comment.
my intention is to have two steps in the tutorial, first describing the CustomerByEmail, which has transform_updates=false and automatically stores the domain.CustomerState. Second step is introducing CustomerByName with transform_updates=true and storing a different CustomerViewState
|
|
||
| // // the view is eventually updated | ||
| await().atMost(10, SECONDS).until(() -> viewClient.getCustomer(req).toCompletableFuture() | ||
| .get(3, SECONDS).getCustomerId().equals(id)); |
There was a problem hiding this comment.
using Awaitility for the "eventually" condition
| .get(3, SECONDS).size() == 2); | ||
|
|
||
| List<CustomerViewModel.CustomerViewState> result = viewClient.getCustomers(req).runWith(Sink.seq(), testkit.getActorSystem()).toCompletableFuture() | ||
| .get(5, SECONDS); |
There was a problem hiding this comment.
this becomes rather low level, but integration tests are not described in the Quickstart
|
added text content in https://github.com/lightbend/akkaserverless-docs/pull/995 |
|
Integration tests here should also be updated to use |
raboof
left a comment
raboof
left a comment
There was a problem hiding this comment.
Nice to separate this out from the java-customer-registry-quickstart as well 👍
| @@ -0,0 +1,85 @@ | |||
| # Quickstart project: Customer Registry | |||
|
|
|||
| # TODO update for quickstart instructions | |||
There was a problem hiding this comment.
I don't know what that refers to. I'll remove all such.
patriknw
force-pushed
the
wip-qs-views-patriknw
branch
from
e79d127 to
48effe0
Compare
|
updated integration tests for the quickstarts |
2 participants
Ready for review, but keeping as draft until I have written the text content
Refs https://github.com/lightbend/akkaserverless-docs/issues/812