Skip to content

chore: generate sources for tck tests for Java SDK#599

Merged
jrudolph merged 6 commits intolightbend:mainfrom
jrudolph:auto-generate-files-for-tck
Oct 12, 2021
Merged

chore: generate sources for tck tests for Java SDK#599
jrudolph merged 6 commits intolightbend:mainfrom
jrudolph:auto-generate-files-for-tck

Conversation

@jrudolph
Copy link
Copy Markdown
Contributor

In this PR, actions, value entities, and event-sourced entities TCK tests are converted to use auto-generated code.

For now, I imported the TCK protos to be more easily editable. When all TCK tests are converted they should be backported to the proxy and then again be imported from there.

Comment thread project/Dependencies.scala Outdated
Comment thread project/ReflectiveCodeGen.scala
Copy link
Copy Markdown
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Copy link
Copy Markdown
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jrudolph is this is ready for merge?

@jrudolph
Copy link
Copy Markdown
Contributor Author

Yes, I fixed the remaining issues.

@jrudolph jrudolph merged commit 1d6a991 into lightbend:main Oct 12, 2021
@jrudolph jrudolph deleted the auto-generate-files-for-tck branch October 12, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants