feat(codegen-scala): add EventSourcedEntity IntegrationSpec template#592
Merged
raboof merged 4 commits intolightbend:mainfrom Oct 12, 2021
Merged
Conversation
raboof
changed the title
Contributor
|
Looks like the Eventsourced counter integration test is failing consistently (I thought it was flaky and retriggered but failed the same way): |
johanandren
approved these changes
Oct 11, 2021
Contributor
johanandren
left a comment
johanandren
left a comment
There was a problem hiding this comment.
LGTM except for the CI failing
CircleCi doesn't allow connecting to docker containers (https://circleci.com/docs/2.0/building-docker-images/#accessing-services) so we'd have to switch to the `machine` executor type.
raboof
force-pushed
the
eventsourced-entity-integrationtest
branch
from
381c460 to
9b61f8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #372