Conversation
| .settings( | ||
| name := "akkaserverless-jvm-sdk", | ||
| crossPaths := false, | ||
| crossPaths := true, |
There was a problem hiding this comment.
I changed this for core. Not sure if that is the right thing to do? I don't think we have a solid solution for cross building the Scala SDK anyway because it has a dependency to Java SDK, which doesn't have crossPaths enabled.
core itself doesn't have any Scala classes yet
Maybe I'll just change this back to false and we deal with the full story when/if there is a need for cross building?
There was a problem hiding this comment.
Also not sure, but true is the default so if we want it true, maybe remove it instead.
There was a problem hiding this comment.
maybe we shouldn't have an core at all, since scala-sdk depends on java-sdk and core only contains a single class (sdk/core/src/main/java/com/akkaserverless/replicatedentity/ReplicatedData.java)?
As long as core only has Java sources crossPaths=false might make sense, not sure.
Since java-sdk contains Scala code, shouldn't we change to crossPaths=true there as well?
There was a problem hiding this comment.
Do we even support anything else than 2.13 right now?
There was a problem hiding this comment.
Do we even support anything else than 2.13 right now?
Only 2.13 now, but I can imagine Scala 3 would come up later.
Since java-sdk contains Scala code, shouldn't we change to crossPaths=true there as well?
The drawback is that the dependency for the Java users becomes _2.13, but I agree that if we ever want to support cross builds the java-sdk must also be be crossPaths=true.
Let's deal with this later when there is a need for cross building.
| Seq( | ||
| Compile / akkaGrpcGeneratedLanguages := Seq(AkkaGrpc.Java), | ||
| Test / akkaGrpcGeneratedSources := Seq(AkkaGrpc.Client), | ||
| Compile / javacOptions ++= Seq("-encoding", "UTF-8", "-source", "11", "-target", "11"), |
There was a problem hiding this comment.
-source was conflicting with -release
This is only used from one of the test projects, but anyway it seems wrong that a plugin like this should set these settings
| .settings( | ||
| name := "akkaserverless-jvm-sdk", | ||
| crossPaths := false, | ||
| crossPaths := true, |
There was a problem hiding this comment.
Also not sure, but true is the default so if we want it true, maybe remove it instead.
patriknw
force-pushed
the
wip-jdk11-patriknw
branch
from
0d44ca6 to
1dc3cdc
Compare
3 participants
References https://github.com/lightbend/akkaserverless/issues/5236
All CI was already on 11