Skip to content

feat: Action testkit for Scala SDK#583

Merged
johanandren merged 8 commits intomainfrom
wip-scala-action-testkit
Oct 8, 2021
Merged

feat: Action testkit for Scala SDK#583
johanandren merged 8 commits intomainfrom
wip-scala-action-testkit

Conversation

@johanandren
Copy link
Copy Markdown
Contributor

Including some fixes on the Java Action testkit side

References #572

@johanandren
Copy link
Copy Markdown
Contributor Author

I went with docs for the same action that @franciscolopezsancho used for the Java testkit, but on second thought I think that for continuity it will be better to add tests for the Fibonacci action shown previously in that page rather than some completely different action. I'll update both.

Copy link
Copy Markdown
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@johanandren
Copy link
Copy Markdown
Contributor Author

johanandren commented Oct 8, 2021

I think I'll look into adding support for streaming calls separately. #590

@johanandren johanandren marked this pull request as ready for review October 8, 2021 12:27
@johanandren johanandren merged commit de80045 into main Oct 8, 2021
@johanandren johanandren deleted the wip-scala-action-testkit branch October 8, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants