Skip to content

bump: update commons-compress (security vulnerabilities) #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raboof merged 1 commit into from
Oct 4, 2021
Merged

bump: update commons-compress (security vulnerabilities) #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ object Dependencies {
val jacksonParameterNames = "com.fasterxml.jackson.module" % "jackson-module-parameter-names" % JacksonVersion
val jacksonScala = "com.fasterxml.jackson.module" %% "jackson-module-scala" % JacksonVersion

val testcontainers = "org.testcontainers" % "testcontainers" % TestContainersVersion
Copy link
Copy Markdown
Contributor

@raboof raboof Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked testcontainers over testContainers as it's written without a - in the artifact name, but 👍

Copy link
Copy Markdown
Member Author

@pvlugter pvlugter Oct 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the official name is Testcontainers as one word. I removed the dependency that wasn't being used. Didn't think of switching to this one.

val scalaTest = "org.scalatest" %% "scalatest" % ScalaTestVersion
val munit = "org.scalameta" %% "munit" % MunitVersion
val munitScalaCheck = "org.scalameta" %% "munit-scalacheck" % MunitVersion
Expand Down Expand Up @@ -98,7 +97,13 @@ object Dependencies {
// FIXME
val sdkJava = sdkCore

val sdkJavaTestKit = deps ++= Seq(testContainers, junit4 % Provided, junit5 % Provided)
val sdkJavaTestKit = deps ++= Seq(
testContainers,
// Override for security vulnerabilities. Can be removed once testcontainers is updated:
// https://github.com/testcontainers/testcontainers-java/issues/4308
"org.apache.commons" % "commons-compress" % "1.21",
junit4 % Provided,
junit5 % Provided)

// FIXME
val sdkScala = deps ++= coreDeps ++ Seq(jacksonScala)
Expand Down