chore: favor usage of FQN for proto component#522
Merged
Conversation
octonato
commented
Sep 28, 2021
octonato
force-pushed
the
rgc/use-fqn-in-proto
branch
from
e10ffa1 to
20c2890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was preparing the value entity video, I found myself having to explain the syntax used to point to the component and came to the conclusion that this is an unnecessary complexity / distraction that we are imposing to the users.
I still think that the annotation as we have today can be simplified to avoid this references, so maybe the change in this PR will become obsolete. Still, I would like to submit it to collect ideas.