chore: verify unmanged integration tests sources compile#520
Merged
johanandren merged 1 commit intomainfrom Sep 29, 2021
Merged
chore: verify unmanged integration tests sources compile#520johanandren merged 1 commit intomainfrom
johanandren merged 1 commit intomainfrom
Conversation
octonato
commented
Sep 28, 2021
| mvn -Dakkaserverless-sdk.version=$SDK_VERSION verify -Pit | ||
| echo "==== Verifying that generated unmanaged sources compile ====" | ||
| rm -rf src/main/java src/test/java | ||
| rm -rf src/main/java src/test/java src/it/java |
Member
Author
There was a problem hiding this comment.
I had to test it myself, but rm -rf won't fail if dir doesn't exist. Therefore I'm adding it everywhere. Possible that some of the samples don't have integration tests, but if they get one day, we will be covered.
johanandren
approved these changes
Sep 29, 2021
johanandren
deleted the
rgc/verify-unmanage-it-tests-sources-compile
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #486, follow up of #505