Conversation
johanandren
approved these changes
Sep 28, 2021
Contributor
johanandren
left a comment
johanandren
left a comment
There was a problem hiding this comment.
LGTM so far except the duplicated tabsets-tags
| include::example$java-valueentity-customer-registry/src/main/proto/customer/domain/customer_domain.proto[tags=declarations;domain] | ||
| ---- | ||
|
|
||
| [.tabset] |
Contributor
There was a problem hiding this comment.
I think this is not right (i did the same in the value entity docs) and that it should be a single [.tabset] for the two language tabs rather.
Contributor
Author
There was a problem hiding this comment.
thanks, I'll change that
Contributor
Author
|
I need to rebase this after #515 because the name change of the sample. |
* still rather many things left as TODO because they depend on the event sourced sample
patriknw
force-pushed
the
wip-view-docs-patriknw
branch
from
2d904a0 to
e397d95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #372